mod_sonic: ifAlias memory leak

sflow · Apr 1, 2021 · dc692de · dc692de
1 parent 7a397bd
commit dc692de
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/hsflowd.spec b/hsflowd.spec
@@ -1,7 +1,7 @@
 Summary: host sFlow daemon
 Name: hsflowd
 Version: 2.0.34
-Release: 2
+Release: 3
 License: http://sflow.net/license.html
 Group: Applications/Internet
 URL: http://sflow.net

diff --git a/src/Linux/mod_sonic.c b/src/Linux/mod_sonic.c
@@ -1046,8 +1046,11 @@ extern "C" {
 	  // This "index" field is neither ifIndex nor osIndex, so ignore it.
 	  if(my_strequal(c_name->str, HSP_SONIC_FIELD_IFSPEED))
 	    prt->ifSpeed = db_getU64(c_val) * HSP_SONIC_FIELD_IFSPEED_UNITS;
-	  if(my_strequal(c_name->str, HSP_SONIC_FIELD_IFALIAS))
+	  if(my_strequal(c_name->str, HSP_SONIC_FIELD_IFALIAS)) {
+	    if(prt->ifAlias)
+	      my_free(prt->ifAlias);
 	    prt->ifAlias = my_strdup(c_val->str);
+	  }
 	  if(my_strequal(c_name->str, HSP_SONIC_FIELD_IFADMINSTATUS))
 	    prt->adminUp = my_strequal(c_val->str, "up");
 	  if(my_strequal(c_name->str, HSP_SONIC_FIELD_IFOPERSTATUS))