-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle saved Windows paths on Unix #100
Conversation
b17a0c6
to
028fc90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the solution is a "create and upload artifacts only when tagging a release or on pull requests, to keep the builds as minimum and fast as possible when just pushing a commit"
Also as self reminder we can omit the ${{
in if
conditionals as stated in the docs:
[...] you may omit the
${{ }}
expression syntax because GitHub Actions automatically evaluates theif
conditional as an expression [...]
You must use the${{ }}
expression syntax or escape with''
,""
, or()
when the expression starts with!
, since!
is reserved notation in YAML format.
Using the${{ }}
expression syntax turns the contents into a string, and strings are truthy. For example,if: true && ${{ false }}
will evaluate to true.
so these may be
if: github.ref_type == 'tag' || github.event_name == 'pull_request'
Assuming it is a fix for #95, I created another fix locally (noticed this one only after I creaeted mine) which is to replace If this fix is going to be good and applied it's great, but note that Also, there are paths like "\server\mypc\sfz\foobar.sfz" on Windows, so |
8ed66e6
to
d4333f7
Compare
d4333f7
to
fa03059
Compare
Closing, #101 merged instead. |
No description provided.