Skip to content

Commit

Permalink
Don't use VSTGUI::CNewFileSelector::setDefaultExtension
Browse files Browse the repository at this point in the history
This fixes a wrong file extension filter in the file dialog under Windows.
It seems that the last added extension is selected as default one due to some wrong selection index. So use the All Files filter as workaround.
  • Loading branch information
redtide committed Mar 10, 2021
1 parent f7fe13c commit 982116a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions plugins/editor/src/editor/Editor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ void Editor::Impl::chooseSfzFile()
SharedPointer<CNewFileSelector> fs = owned(CNewFileSelector::create(frame_));

fs->setTitle("Load SFZ file");
fs->setDefaultExtension(CFileExtension("SFZ", "sfz"));
fs->addFileExtension(CFileExtension("SFZ", "sfz"));

// also add extensions of importable files
fs->addFileExtension(CFileExtension("WAV", "wav"));
Expand Down Expand Up @@ -1110,7 +1110,7 @@ void Editor::Impl::createNewSfzFile()
SharedPointer<CNewFileSelector> fs = owned(CNewFileSelector::create(frame_, CNewFileSelector::kSelectSaveFile));

fs->setTitle("Create SFZ file");
fs->setDefaultExtension(CFileExtension("SFZ", "sfz"));
fs->addFileExtension(CFileExtension("SFZ", "sfz"));

std::string initialDir = getFileChooserInitialDir(currentSfzFile_);
if (!initialDir.empty())
Expand Down Expand Up @@ -1202,7 +1202,7 @@ void Editor::Impl::chooseScalaFile()
SharedPointer<CNewFileSelector> fs = owned(CNewFileSelector::create(frame_));

fs->setTitle("Load Scala file");
fs->setDefaultExtension(CFileExtension("SCL", "scl"));
fs->addFileExtension(CFileExtension("SCL", "scl"));

std::string initialDir = getFileChooserInitialDir(currentScalaFile_);
if (!initialDir.empty())
Expand Down

0 comments on commit 982116a

Please sign in to comment.