Add the support of FLAC loops #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfd
approved these changes
May 22, 2020
| fread(riffId, 4, 1, stream.get()) == 1 && memcmp(riffId, "smpl", 4) == 0 && | ||
| fread_u32le(stream.get(), riffChunkSize) && riffChunkSize <= block_size - 12) | ||
| { | ||
| std::unique_ptr<uint8_t[]> chunk { new uint8_t[riffChunkSize] }; |
There was a problem hiding this comment.
How big is riffChunkSize here? If we ignore values that are too crazy we could stack-allocate this with std:array (and get an implicit cast to const span later too).
There was a problem hiding this comment.
The chunk size has a fixed header, followed by arbitrary number of loops, followed by the sampler-specific chunk.
Here I'm fine with alloc'ing this chunk, because this is checked to be no larger than the FLAC metadata block. The block has a size encoded in 24 bits, which makes it 16MB in the worst case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#229
This adds the support of FLAC loops, the same as ARIA.
This is not yet supported in libsndfile: libsndfile/libsndfile#59.
Hence this uses an ad-hoc implementation based on direct file parsing.
This is NOT the tag-based implementation. Tag-based support may be added as extra in the future.
This uses a feature known as foreign RIFF blocks.
These blocks are obtained by encoding a WAV file by the FLAC command-line encoder, using the flag
--keep-foreign-metadata.Example
FLAC_loop_test.zip
Reference