Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LV2 problems with the atom sequence #269

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Fix LV2 problems with the atom sequence #269

merged 3 commits into from
Jun 12, 2020

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Jun 12, 2020

  • pop the frame when finished writing
  • add safety checks in case write space is short

@jpcima
Copy link
Collaborator Author

jpcima commented Jun 12, 2020

In the last commit:

  • avoid casting a char[] into LV2_Atom*, which might result in a misalignement
  • the null-termination was removed for simplicity. atom forge is already null-terminating buffers, so this one is probably redundant.

@jpcima jpcima marked this pull request as draft June 12, 2020 18:48
jpcima added 2 commits June 12, 2020 21:41
@jpcima
Fix LV2 problems with the atom sequence
ff34bb5 
- pop the frame when finished writing
- add safety checks in case write space is short
@jpcima
Construct work atoms using a forge
f15ed45
@jpcima jpcima force-pushed the lv2 branch 2 times, most recently from 963b836 to f15ed45 Compare June 12, 2020 19:42
@jpcima jpcima marked this pull request as ready for review June 12, 2020 19:55
@jpcima jpcima merged commit f120cad into sfztools:develop Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpcima