Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require an explicit hikey/key=-1 to trigger on CC #315

Merged
merged 3 commits into from
Jul 6, 2020
Merged

Don't require an explicit hikey/key=-1 to trigger on CC #315

merged 3 commits into from
Jul 6, 2020

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Jul 5, 2020

Closes #239

@paulfd paulfd requested a review from jpcima July 5, 2020 21:38
@jpcima
Copy link
Collaborator

jpcima commented Jul 5, 2020

so lokey is not concerned by -1 values?

@paulfd
Copy link
Member Author

paulfd commented Jul 5, 2020

Well, in the PLJ page they said only key and hikey. Apparently it did not catch on 🙂

@paulfd paulfd mentioned this pull request Jul 6, 2020
Closed
@paulfd
Copy link
Member Author

paulfd commented Jul 6, 2020

Updated so that you may actually trigger on both CC and key, matching Sforzando's behavior. @jpcima if you're still OK I'll merge it now.

@jpcima
Copy link
Collaborator

jpcima commented Jul 6, 2020

Sure yes, it makes sense, please do.

@paulfd paulfd merged commit eca794a into sfztools:develop Jul 6, 2020
@paulfd paulfd deleted the trigger-on-cc branch July 6, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcima jpcima jpcima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger on CC incorrect
2 participants
@paulfd @jpcima