Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulations trigger and release #386

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Aug 21, 2020

This adds a couple of desired features for implementing EG in MM.

  • ability to pass the frame delay to make the modulator source startup frame-accurate +update LFO to use it
  • allow MM sources to be notified from Voice::release, so it's able to signal all EG present in a voice to release themselves

@jpcima jpcima requested a review from paulfd August 21, 2020 12:56
@jpcima jpcima mentioned this pull request Aug 21, 2020
@paulfd
Copy link
Member

paulfd commented Aug 21, 2020

Ok for me! Approving bugs on my phone...

@jpcima jpcima merged commit 2e65a36 into sfztools:develop Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants