Overflow voices #477
Merged
Overflow voices #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will naturally be used for "dying" voices beyond the engine polyphony
paulfd
force-pushed
the
overflow-voices
branch
from
2557393 to
02a1615
Compare
jpcima
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates more voices that asked for using
setNumVoices(...)for example. These "overflow" voices participate in the usual rendering, but a polyphony check is done so that the "required" number of voices is not reached. When the "required" polyphony is reached, stolen voices will be fast released, which avoids most clicking.This solves a corruption problem lingering in the previous version due to the fact that before, stolen voices due to engine polyphony limits were rendered outside of the normal operation of the modulation matrix, leading to weird issues.