Implement LFOs v1 #693
Merged
Implement LFOs v1 #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcima
force-pushed
the
lfos-v1-refactor
branch
from
ca03fa2 to
7f2daa2
Compare
|
Merging this because it passes tests, checked against ARIA in various cases, and for avoidance of future conflicts following the refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements LFO v1 mostly.
Some opcodes still not done. (that's the depthcc, also to implement in v2)
Based on the large refactor PR.
Note that amplfo controls Volume not Amplitude. (outputs additive decibels)
All 3 LFO have behavior matched to ARIA.
EDIT(1) correct an implementation bug which would introduce a regression in v2 LFO