Add lfoN_fade_oncc, lfoN_delay_oncc, lfoN_phase_oncc #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The phase modifier is actually an "audio rate" modifier with curve, step and smoothcc options. The v2 spec only had oncc, which would limit it to a set value with the LFO starts, but having it at audio rate makes sense if you want to tweak the phase while the LFO is running.
|
Should be ok now ! |
jpcima
reviewed
Mar 30, 2021
jpcima
reviewed
Mar 30, 2021
jpcima
reviewed
Mar 30, 2021
| impl.fadePosition_ = (desc.fade > 0) ? 0.0f : 1.0f; | ||
| float fade = desc.fade; | ||
| for (const auto& mod: desc.fadeCC) | ||
| fade += mod.data * state.getCCValue(mod.cc); |
There was a problem hiding this comment.
Can we get the well-timed value with respect to triggerDelay ? same also above
jpcima
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phase modifier is actually an "audio rate" modifier with curve, step and smoothcc options.
The v2 spec only had oncc, which would limit it to a set value with the LFO starts, but having it at audio rate makes sense if you want to tweak the phase while the LFO is running.
I'll add some tests.