Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC input #945

Merged
merged 5 commits into from
Sep 21, 2021
Merged

CC input #945

merged 5 commits into from
Sep 21, 2021

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Jul 6, 2021

Closes: #882

  • Add an EditValue in the knob
  • Shade the knobs when editing
  • Right-click on the knob allows to change from low resolution to high resolution CC

@jpcima I'm having a remaining issue with mostly (?) the Pan knob (second knob in the page). When you try to move it it jumps. This doesn't happen with other knobs and for the life of me I can't really find why atm.

Edit: ^ does not bug out on Windows....

@paulfd paulfd marked this pull request as draft July 6, 2021 23:28
@paulfd paulfd force-pushed the cc-input branch 2 times, most recently from 25398b2 to ed88e35 Compare July 9, 2021 15:51
@paulfd paulfd marked this pull request as ready for review July 14, 2021 23:10
@paulfd paulfd requested a review from jpcima July 14, 2021 23:11
- Add an EditValue in the knob
- Shade the knobs when editing
- Right-click on the knob allows to change from low resolution to high resolution CC
@alcomposer
Copy link
Collaborator

alcomposer commented Jul 15, 2021

I understand this is a WIP
I have tested this feature, here are a few UX thoughts:

  1. Right click menu is fantastic, works really well for the hi/lo res mode select.
  2. There needs to be a visual way to distinguish between hi/lo res mode. I suggest a badge in the CC number space. Because right now, a musician has no way to know if value 1 is 0-1 or 0-127.
  3. It's too easy to mistakenly enter the keyboard entry mode for knobs. Possibly use double click, or alternatively place it into the right click menu Edit Value, as how Surge achieves this:
    surge_edit_value
  4. I'm not sure we need the grey highlight behind the knob. Right now it doesn't feel integrated.

@alcomposer
Copy link
Collaborator

Two notes from 63c1af9:

  • Ardour Linux doesn't default to linear mouse knob mode
  • Data entry for value should be limited to numeric only

@paulfd
Copy link
Member Author

paulfd commented Jul 23, 2021

  • Ardour forces all UIs to the relative circular knob mode
  • Invalid input result is ignored, is that a big issue? Seems OK to me like this...

@alcomposer
Copy link
Collaborator

alcomposer commented Jul 24, 2021

Ardour doesn't use rotary mouse interaction knob mode itself... I think it would be best to make it standard.

Is this something on the Ardour end?

@paulfd
Copy link
Member Author

paulfd commented Sep 21, 2021

Ardour should be fixed iirc, so I'll merge this.

@paulfd paulfd merged commit 2ca137f into sfztools:develop Sep 21, 2021
@paulfd paulfd deleted the cc-input branch January 21, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: CC Keyboard entry
2 participants