-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: finish login & join View components #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
커멘트 남겼습니다 👍 👍
inflater: LayoutInflater, container: ViewGroup?, | ||
savedInstanceState: Bundle? | ||
): View { | ||
Log.d("CreateAccountFragment", "onCreateView called") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로그들은 불필요할 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 추후로 미뤄둔 LoginFragment
, PasswordFragment
를 제외한 로그는 지웠습니다~
if (clickedText == "쿠키 사용" || clickedText == "이용 약관" || clickedText == "개인정보 처리방침" | ||
|| clickedText == "자세히" || clickedText == "알아보기" || clickedText == "여기") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위에서 targetTexts
리스트를 정의했는데 리스트에 clickedText가 find? include? 되어있는지 검사하는건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
targetTexts
를 맨 위에 private
로 빼고 반영했습니다~
(event != null && event.action == KeyEvent.ACTION_DOWN && | ||
event.keyCode == KeyEvent.KEYCODE_ENTER) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
별건 아닌데 자주 쓰일 것 같은 조건문이라 유틸함수로 바꾸는건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain
패키지에 Utils.kt
로 유틸 함수 클래스를 분리해서 사용하게 변경했습니다~
private fun validatePassword() { | ||
val password = binding.needPasswordFragmentPwField.text.toString() | ||
|
||
if (password.length < 8) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8이라는 숫자보단 val MAX_PASSWORD_LENGTH = 8
로 쓰면 매직넘버가 없어질 것 같습니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maxPasswordLength
로 바꿔서 사용했습니다ㅎㅎ
|
||
// 텍스트 변경 후에 호출되는 메소드 | ||
override fun afterTextChanged(s: Editable?) { | ||
if (s?.contains(" ") == true || s?.contains("\n") == true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요런 조건문도 많은데 유틸함수로 바꾸는건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마찬가지로 domain
패키지에 Utils.kt
로 유틸 함수 클래스를 분리해서 사용하게 변경했습니다~
src/mobile/app/src/main/res/drawable/bg_profile_image_picker.xml
Outdated
Show resolved
Hide resolved
리뷰 반영 완료했습니다~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무 고생하셨습니다 :)
@@ -154,8 +155,7 @@ class CreateAccountFragment : Fragment() { | |||
|
|||
private fun handleTextClick(clickedText: String) { | |||
// 클릭된 텍스트에 따라 동작 수행 | |||
if (clickedText == "쿠키 사용" || clickedText == "이용 약관" || clickedText == "개인정보 처리방침" | |||
|| clickedText == "자세히" || clickedText == "알아보기" || clickedText == "여기") { | |||
if (clickedText in targetTexts) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
와 진짜 편하네요 👍
* feat: add start & login fragment for android (#26) * feat: setting android development environment * feat: setting navigation graph * feat: setting ktlint * feat: setting ktlint * feat: setting ktlint * chore: test eol at new file * chore: add eol to files * chore: add eol to gitignore * chore: add colorList * chore: add font_resource & font_style xml * chore: add font style themes * chore: edit theme colors * chore: edit font style themes * feat: add startFragment & edit MainActivity, nav_graph * feat: add lottieAnimation in Gradle & startFragment * feat: edit lottieAnimation size * chore: add icons * feat: add loginFragment & strings * feat: add nagivation start to login & loginFragment ui xml * feat: add String and edit login & loginFragment ui xml * feat: add nagivation login to password & PasswordFragment ui xml * chore: edit letterspacing in themes.xml * chore: review apply * chore: edit home icon * feat: add find account Fragment & edit font system in themes (#35) * chore: add green check icon * feat: add FindAccountFragment * feat: edit FindAccountFrangmet for basic setting * feat: add FindAccountFragment String * feat: add navigation action in loginFragment & PasswordFragment * chore: edit font system in themes * chore: edit textStyle in fragment_password * feat: add CheckIdFragment * feat: delete checkidFragment & edit FindAccountFragment btn ui & add underline for passwordFragment string * feat: edit id name in login/findAccount Fragment * feat: edit headline weight in fragments * chore: edit textStyle & delete view in startFragment * feat: finish login & join View components (#58) * feat: add createAccountFragment * feat: add string for createAccountFragment * feat: edit xml for CreateAccountFragment Ui * feat: add navigation Action for createAccountFragment * feat: add action for check icon in CreateAccountFragment * feat: edit string for CreatAccountFragment * chore: add icons for password/profile * feat: edit textcolor for announcement & add toast message * feat: add SendCodeFragment * feat: add strings for SendCodeFragment * feat: add navigation Action for SendCodeFragment * feat: edit xml & fragment code for SendCodeFragment * feat: edit string to remove phoneNum & add email/Number Keypad for editText * feat: add NeedPasswordFragment * feat: add strings for NeedPasswordFragment * feat: edit xml & fragment code for NeedPasswordFragment * feat: add navigation Action for NeedPasswordFragment * feat: edit directory structure for viewmodel(MVVM) & add JoinViewModel * feat: add ProfileImageFragment * feat: add string for ProfileImageFragment * feat: edit xml & fragment code for ProfileImageFragment * feat: add navigation Action for ProfileImageFragment * feat: add Fragment & string for AskNameFragment * feat: edit xml & fragment code for AskNameFragment * feat: add navigation Action for AskNameFragment * feat: remove skip btn in AskNameFragment * feat: edit JoinViewModel for send livedata fragment to fragment * feat: edit NeedPasswordFragment to Setting icon action for password inputType On/Off * feat: edit profileImageFragment to link icon to Gallery * feat: forbid keybord action(space, enter) * feat: edit PasswordFragment to Setting icon action for password inputType On/Off * feat: add viewmodel for login View * feat: add button activation for all fragments * feat: change lottie animation * feat: remove underline in EditText * feat: add hint animation in join View * feat: add hint animation in login View * feat: add validate check for NeedPasswordFragment & add Toast for sendEmail * feat: add validate check for CreateAccountFragment * feat: edit ImageView to CardView * feat: add Image delete btn & logic in ProfileImageFragment * feat: add keypad dependency in buttons * feat: edit viewmodel to bundle in login->password logic * feat: edit FindAccountFragment to remove underline in editText * feat: remove log * chore: reflect review * feat: edit eol * feat: add toolbar & bottom navigation bar (#71) * feat: add toolbar & navigation bar basic setting * feat: change constraintLayout into LinearLayout to pix location & add TimelineFragment * feat: edit toolbar navigate icon & actions for login/join Views * feat: setting basic things for timelineFragment * feat: add toolbar icon in TimelineFragment * feat: create Fragments for add bottom navigation bar * feat: edit activity_main.xml for toolbar/navbar/fragmentContainer view problem * feat: edit margin in loginFragment * edit bottom_nav * feat: chained fragmentContainerView in activityMain * feat: edit toolbar & bottom navigationbar * feat: delete sucks itemActiceIndicator * feat: clear doubleClicked icon focus issue * chore: add eol * chore: reflect review * chore: reflect review * chore: reflect review * feat: add RecyclerView & TabLayout in TineLine Fragment (#78) * chore: edit nav_bar visibility for easy dev * feat: add profile icon for toolbar * feat: add action for profile icon to navigate ProfileFragment * feat: add adapter for TimelineFragment & add Tablayout/ViewPager * feat: add ForToyFragment/TimeLineFragment & edit toolbar bg/indicator color * feat: add item_timeline for timeline RecyclerView * feat: edit item_timeline for timeline RecyclerView * feat: edit TimeLineItem dataclass for nullable components * feat: add recyclerView in FollowingFragment * feat: edit profileImg to nullable & remove touch animation in bottombar * feat: add scroll action save logic in RV * feat: add json file & edit icon size * chore: add icons for post menu * feat: edit TimelineRVAdapter
* feat: add start & login fragment for android (#26) * feat: setting android development environment * feat: setting navigation graph * feat: setting ktlint * feat: setting ktlint * feat: setting ktlint * chore: test eol at new file * chore: add eol to files * chore: add eol to gitignore * chore: add colorList * chore: add font_resource & font_style xml * chore: add font style themes * chore: edit theme colors * chore: edit font style themes * feat: add startFragment & edit MainActivity, nav_graph * feat: add lottieAnimation in Gradle & startFragment * feat: edit lottieAnimation size * chore: add icons * feat: add loginFragment & strings * feat: add nagivation start to login & loginFragment ui xml * feat: add String and edit login & loginFragment ui xml * feat: add nagivation login to password & PasswordFragment ui xml * chore: edit letterspacing in themes.xml * chore: review apply * chore: edit home icon * feat: add find account Fragment & edit font system in themes (#35) * chore: add green check icon * feat: add FindAccountFragment * feat: edit FindAccountFrangmet for basic setting * feat: add FindAccountFragment String * feat: add navigation action in loginFragment & PasswordFragment * chore: edit font system in themes * chore: edit textStyle in fragment_password * feat: add CheckIdFragment * feat: delete checkidFragment & edit FindAccountFragment btn ui & add underline for passwordFragment string * feat: edit id name in login/findAccount Fragment * feat: edit headline weight in fragments * chore: edit textStyle & delete view in startFragment * feat: finish login & join View components (#58) * feat: add createAccountFragment * feat: add string for createAccountFragment * feat: edit xml for CreateAccountFragment Ui * feat: add navigation Action for createAccountFragment * feat: add action for check icon in CreateAccountFragment * feat: edit string for CreatAccountFragment * chore: add icons for password/profile * feat: edit textcolor for announcement & add toast message * feat: add SendCodeFragment * feat: add strings for SendCodeFragment * feat: add navigation Action for SendCodeFragment * feat: edit xml & fragment code for SendCodeFragment * feat: edit string to remove phoneNum & add email/Number Keypad for editText * feat: add NeedPasswordFragment * feat: add strings for NeedPasswordFragment * feat: edit xml & fragment code for NeedPasswordFragment * feat: add navigation Action for NeedPasswordFragment * feat: edit directory structure for viewmodel(MVVM) & add JoinViewModel * feat: add ProfileImageFragment * feat: add string for ProfileImageFragment * feat: edit xml & fragment code for ProfileImageFragment * feat: add navigation Action for ProfileImageFragment * feat: add Fragment & string for AskNameFragment * feat: edit xml & fragment code for AskNameFragment * feat: add navigation Action for AskNameFragment * feat: remove skip btn in AskNameFragment * feat: edit JoinViewModel for send livedata fragment to fragment * feat: edit NeedPasswordFragment to Setting icon action for password inputType On/Off * feat: edit profileImageFragment to link icon to Gallery * feat: forbid keybord action(space, enter) * feat: edit PasswordFragment to Setting icon action for password inputType On/Off * feat: add viewmodel for login View * feat: add button activation for all fragments * feat: change lottie animation * feat: remove underline in EditText * feat: add hint animation in join View * feat: add hint animation in login View * feat: add validate check for NeedPasswordFragment & add Toast for sendEmail * feat: add validate check for CreateAccountFragment * feat: edit ImageView to CardView * feat: add Image delete btn & logic in ProfileImageFragment * feat: add keypad dependency in buttons * feat: edit viewmodel to bundle in login->password logic * feat: edit FindAccountFragment to remove underline in editText * feat: remove log * chore: reflect review * feat: edit eol * feat: add toolbar & bottom navigation bar (#71) * feat: add toolbar & navigation bar basic setting * feat: change constraintLayout into LinearLayout to pix location & add TimelineFragment * feat: edit toolbar navigate icon & actions for login/join Views * feat: setting basic things for timelineFragment * feat: add toolbar icon in TimelineFragment * feat: create Fragments for add bottom navigation bar * feat: edit activity_main.xml for toolbar/navbar/fragmentContainer view problem * feat: edit margin in loginFragment * edit bottom_nav * feat: chained fragmentContainerView in activityMain * feat: edit toolbar & bottom navigationbar * feat: delete sucks itemActiceIndicator * feat: clear doubleClicked icon focus issue * chore: add eol * chore: reflect review * chore: reflect review * chore: reflect review * feat: add RecyclerView & TabLayout in TineLine Fragment (#78) * chore: edit nav_bar visibility for easy dev * feat: add profile icon for toolbar * feat: add action for profile icon to navigate ProfileFragment * feat: add adapter for TimelineFragment & add Tablayout/ViewPager * feat: add ForToyFragment/TimeLineFragment & edit toolbar bg/indicator color * feat: add item_timeline for timeline RecyclerView * feat: edit item_timeline for timeline RecyclerView * feat: edit TimeLineItem dataclass for nullable components * feat: add recyclerView in FollowingFragment * feat: edit profileImg to nullable & remove touch animation in bottombar * feat: add scroll action save logic in RV * feat: add json file & edit icon size * chore: add icons for post menu * feat: edit TimelineRVAdapter * feat: add bottomSheetDialog & Menu & FAB (#114) * feat:add bottomSheetDialog for Timeline * feat:add bottomSheetDialog xml for Timeline * feat: add behavior navigationBar & edit bottomsheet * feat: add fab btn & animation in timeline Fragment * feat: add fab btn & animation in timeline Fragment * fix: edit Viewpager overFlow * fix:remove bottomSheetDialog * feat: edit fab margin in constraintlayout * feat: add dummy data for Timeline * feat: add fab in navigation Fragment * feat: edit fab in messageFragment * feat: add vibrate for longClick * feat: add icons for popupmenu & add basic popupMenu * feat: add custom popup menu xml * feat: add custom popup into TimeLineRVAdapter * feat: edit custom popup tv * feat: add bottomSheetDialog * chore: rename Timeline package to timeline * feat: add post Fragment * feat: add navigation actions to post Fragment * feat: add actions for fab to PostFragment * fix: fix navigation actions to post Fragment * feat: add xml for ProfileFragment * feat: add action in MypageFragment(before ProfileFragment) * feat: add toggle action in MypageFragment * feat: add lightMode icon & Toast * feat: try to add animation in MyPageFragment * feat: add overlay view in TimelineFragment * feat:divide bottomSheetDialog into Rt & share * feat: add Toast into MyPageFragment * feat: add ViewBottomSheetDialog * feat: edit button to android.widget.button * chore: add eol * chore: reflect review * chore:reflect review * feat: add ic_up_arrow * chore:reflect review * feat: fix FAB animation bug * chore:reflect review * feat: remove elevation in bottomSheet btn * feat: add ProfileFragment & BookMarkFragment (#121) * feat: add profileFragment.xml before tablayout * feat: add viewPager & TabLayout in ProfileFragment * feat: add RV in MyPostFragment & edit doublePressed Logic in ForYou/Following Fragment * feat: add RV in ReplyFragment * feat: add RV in LikedFragment * feat: add RV in MediaFragment * feat: add RV in HighlightFragment * feat: change scrollview into NestedScrollView * feat: try to change statusBar Transperent * feat: add naviation for ProfileFragment & ViewPager * feat: Edit HighlighFragment to subscribe xml * feat: add FAB in ProfileFragment * feat: edit toobal & navBar visibility * feat: add BookMarkFragment & nav Actions * feat: add RV & toolbar Visibility for BookMarkFragment * feat: add layout for when bookMark is empty * feat: edit navigation in MyPageFragment * chore: add icon * chore: add eol * feat: add scroll action in ProfileFragment (#158) * chore: remove unused behavior.kt * feat: add SwipeRefresh in Timeline * feat: try to forbid basicBackbtn in ProfileFragment * feat: add nestedScrollableHost/icon & edit color theme name * chore: add Timber in Dependency & MainActivity * feat: remove scrollView in RV * feat: remove scrollView in RV * feat: remove scrollView in RV * feat: divide ConstraintLayout into 2 * feat: edit xml for scrollView * feat: add action in backbtn for ProfileFragment * feat: add SwipeRefresh in xml * feat: add swipe action in Tablayout * extract Method for RV in ProfileFragment * feat: try to add Highlight RV for ProfileFragment Tablayout * feat: make FAB cannot scroll * chore:add eol * feat: edit popupMenu constraintLayout * chore: add eol * chore: reflect review * chore: reflect review * chore: reflect review * chore: reflect review * chore: reflect review * chore: add eol * chore: add eol * feat: add PostFragment (#234) * feat: remove toolbar&navigation in PostFragment * feat: edit fragment_post.xml * feat: edit post_fragment.xml * feat: add textWatcher action & photo plus btn in PostFragment * feat: add CircularProgressBar * feat: add CircularProgressBar * fix: edit constraintLayout for editText space * fix: add img RV in PostFragment * fix: add horizontalScrollView * feat: link Gallery to PostFragment RV with Glide * feat: add border & cardView in Item_post_img * feat: add action for backbtn in PostFragment * chore:edit opacity for popup menu * feat: load Img from gallery to PostFragment * feat: change view's ConstraintLayout in PostFragment * feat: change enable btn in postFragment * feat: change deleteBtn translationZ * fix: fix upload sequence error * feat: add setOnClickListener in Horizontal RV * feat: change enable btn in postFragment * feat: change enable btn when add img in postFragment * chore:reflect review * chore:reflect review * chore:reflect review * chore:reflect review * feat: add quote & detail fragment (#279) * feat: add quote text & image ver * feat: add MultiView(quote text & image) in RV * feat: edit MultiView(quote text & image) margin & border in RV * feat: set Visibility for MultiView(quote text & image) in RV * feat: add margin for MultiView(quote text & image) in RV * feat: add postDetailFragment * feat: add item_post_detail.xml * feat: edit item_post_detail.xml * feat: add api for login&join (#292) * feat:add api(users/verify-email, users/temporary-join) * feat:add api(auth) * feat:add api(user/join) except profileImg * feat:add api(auth/mobile) & tokenManager * feat:add api(users/me)
Related Issue
#25
Changes
작업 사항
CreateAccountFragment
loginFragment
findAccountFragment
입력 필드 차야 확인 버튼 활성화passwordFragment
입력 필드 차야 확인 버튼 활성화sendCodeFragment
만들기CreateAccountFragment
->sendCodeFragment
이메일 넘겨주기needPasswordFragment
만들기visibiliy
속성 전환 할 수 있게 적용하기profileImageFragment
만들기askNameFragment
만들기기타 수정사항
Screenshots
To Reviewer
LoginFragment
->PasswordFragment
작업은...헤더랑 네비게이션 pr 올리고 수정하겠습니다..ㅎㅎChecklist