Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support for GPT-2 #1643

Closed
2 tasks done
hariharan98m opened this issue Oct 12, 2024 · 5 comments
Closed
2 tasks done

[Feature] Support for GPT-2 #1643

hariharan98m opened this issue Oct 12, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@hariharan98m
Copy link

hariharan98m commented Oct 12, 2024

Checklist

Motivation

I believe there is still a vast majority of our community working with GPT-2 or similar small language models for niche datasets. It would be great if these finetuned GPT-2 models can be deployed through sglang.

Related resources

No response

@Abhrajitdas02
Copy link

hi can I work on this?

@zhyncs
Copy link
Member

zhyncs commented Oct 17, 2024

hi can I work on this?

Sure, go ahead. It's not difficult. ref https://github.com/vllm-project/vllm/blob/main/vllm/model_executor/models/gpt2.py

@merrymercy merrymercy added the good first issue Good for newcomers label Oct 25, 2024
@merrymercy
Copy link
Contributor

@DanielC12321
Copy link
Contributor

Hi! Is anyone currently working on this issue? If not, I’d love to take it on. I’m new to contributing, so any pointers on where to start or key files to review would be really helpful.

DanielC12321 added a commit to DanielC12321/sglangGPT2 that referenced this issue Oct 29, 2024
@DanielC12321 DanielC12321 mentioned this issue Oct 29, 2024
@merrymercy
Copy link
Contributor

implemented by #1833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants