Use a single workspace for flashinfer #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
commented
Aug 15, 2024
merrymercy
force-pushed
the
flashinfer-merge-buffer
branch
2 times, most recently
from
6322cde to
7383909
Compare
merrymercy
force-pushed
the
flashinfer-merge-buffer
branch
from
7383909 to
44ed280
Compare
hnyls2002
reviewed
Aug 15, 2024
| @@ -27,7 +27,7 @@ def __init__(self): | |||
| # Runtime constants: others | |||
| self.num_continue_decode_steps = 10 | |||
| self.retract_decode_steps = 20 | |||
| self.flashinfer_workspace_size = 192 * 1024 * 1024 | |||
| self.flashinfer_workspace_size = 384 * 1024 * 1024 | |||
There was a problem hiding this comment.
Yeah, we truly need this large work space... otherwise the chunked prefill would probably crash.
|
Why the UT failed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with flashinfer >= 0.1.5, we can use a single workspace buffer for all wrappers.