Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update timeout and retry #1086

Merged
merged 2 commits into from
Aug 14, 2024
Merged

ci: update timeout and retry #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a685015
ci: update timeout
zhyncs Aug 14, 2024
c985a13
Update test/srt/test_moe_serving_throughput.py
hnyls2002 Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/accuracy-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ on:
paths:
- "python/sglang/**"
- "test/**"
- ".github/workflows/accuracy-test.yml"
pull_request:
branches: [ main ]
paths:
- "python/sglang/**"
- "test/**"
- ".github/workflows/accuracy-test.yml"
workflow_dispatch:

concurrency:
Expand Down Expand Up @@ -43,4 +45,4 @@ jobs:
run: |
cd test/srt
python3 test_eval_accuracy_large.py
timeout-minutes: 20
timeout-minutes: 10
5 changes: 5 additions & 0 deletions .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ on:
paths:
- "python/sglang/**"
- "test/**"
- ".github/workflows/e2e-test.yml"
pull_request:
branches: [ main ]
paths:
- "python/sglang/**"
- "test/**"
- ".github/workflows/e2e-test.yml"
workflow_dispatch:

concurrency:
Expand Down Expand Up @@ -39,13 +41,16 @@ jobs:
run: |
cd test/srt
python3 -m unittest test_serving_throughput.TestServingThroughput.test_default
timeout-minutes: 10

- name: Benchmark Serving Throughput (w/o RadixAttention)
run: |
cd test/srt
python3 -m unittest test_serving_throughput.TestServingThroughput.test_default_without_radix_cache
timeout-minutes: 10

- name: Benchmark Serving Throughput (w/ ChunkedPrefill)
run: |
cd test/srt
python3 -m unittest test_serving_throughput.TestServingThroughput.test_default_with_chunked_prefill
timeout-minutes: 10
15 changes: 11 additions & 4 deletions .github/workflows/moe-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ on:
paths:
- "python/sglang/**"
- "test/**"
- ".github/workflows/moe-test.yml"
pull_request:
branches: [ main ]
paths:
- "python/sglang/**"
- "test/**"
- ".github/workflows/moe-test.yml"
workflow_dispatch:

concurrency:
Expand All @@ -36,7 +38,12 @@ jobs:
pip install flashinfer -i https://flashinfer.ai/whl/cu121/torch2.4/ --force-reinstall

- name: Benchmark MOE Serving Throughput
run: |
cd test/srt
python3 -m unittest test_moe_serving_throughput.TestServingThroughput.test_default
python3 -m unittest test_moe_serving_throughput.TestServingThroughput.test_default_without_radix_cache
uses: nick-fields/retry@v3
with:
timeout_minutes: 15
max_attempts: 2
retry_on: error
command: |
cd test/srt
python3 -m unittest test_moe_serving_throughput.TestServingThroughput.test_default
python3 -m unittest test_moe_serving_throughput.TestServingThroughput.test_default_without_radix_cache
4 changes: 4 additions & 0 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ on:
paths:
- "python/sglang/**"
- "test/**"
- ".github/workflows/unit-test.yml"
pull_request:
branches: [ main ]
paths:
- "python/sglang/**"
- "test/**"
- ".github/workflows/unit-test.yml"
workflow_dispatch:

concurrency:
Expand Down Expand Up @@ -41,8 +43,10 @@ jobs:
run: |
cd test/srt
python3 run_suite.py --suite minimal
timeout-minutes: 15

- name: Test Frontend Language
run: |
cd test/lang
python3 run_suite.py --suite minimal
timeout-minutes: 10
2 changes: 1 addition & 1 deletion test/srt/test_moe_serving_throughput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def test_default(self):

if os.getenv("SGLANG_IS_IN_CI", "false") == "true":
# A100 (PCIE) performance
assert res["output_throughput"] > 950
assert res["output_throughput"] > 930

def test_default_without_radix_cache(self):
res = self.run_test(
Expand Down
Loading