Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: rm unused model_loader #1110

Merged
merged 1 commit into from
Aug 15, 2024
Merged

misc: rm unused model_loader #1110

merged 1 commit into from
Aug 15, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Aug 15, 2024

Motivation

While reviewing the code, it was discovered that this section of code is not being used and seems to have been broken up. For example, in python/sglang/srt/model_loader/utils.py, from sglang.srt.layers.quantization import get_quantization_config, but actually there is no quantization file under the layers directory anymore. This should be due to incomplete deletion previously.

Modification

Checklist

  • Before submitting a PR for review, make sure it has passed verification in your local development environment at least.
  • Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  • Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  • Modify documentation as needed, such as docstrings or example tutorials.

@merrymercy merrymercy merged commit 9195d13 into sgl-project:main Aug 15, 2024
5 checks passed
@zhyncs zhyncs deleted the misc branch August 15, 2024 15:35
hnyls2002 pushed a commit to yichuan520030910320/sglang that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants