-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] add disable-custom-all-reduce #1148
[Feature] add disable-custom-all-reduce #1148
Conversation
c0d9374
to
5e065b3
Compare
@Xu-Chen May you use |
|
@Xu-Chen Could you try using |
@Xu-Chen Thanks for the contribution. It is merged. |
@Xu-Chen I am wondering what is the performance drop after disabling the custom_all_reduce? |
About 5% ~ 10% |
Motivation
Sometimes, we need to turn off Custom allreduce.
Especially on A800 with tp, to avoid timeout problems caused by NCCL communication.
Error like:vllm-project/vllm#6614
This may be the reason, not sure, but after setting disable-custom-all-reduce, the problem no longer occurs.
Modification
Checklist
pre-commit run --all-files
or other linting tools are used to fix potential lint issues.