Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace GeluAndMul #1234

Merged
merged 2 commits into from
Aug 28, 2024
Merged

feat: replace GeluAndMul #1234

merged 2 commits into from
Aug 28, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Aug 27, 2024

Motivation

as titled

Await https://github.com/flashinfer-ai/flashinfer/releases/tag/v0.1.6

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhyncs zhyncs added the wip label Aug 27, 2024
@zhyncs zhyncs self-assigned this Aug 27, 2024
@zhyncs zhyncs marked this pull request as draft August 27, 2024 14:07
@yzh119
Copy link
Collaborator

yzh119 commented Aug 28, 2024

v0.1.6 wheels are ready: https://github.com/flashinfer-ai/flashinfer/releases/tag/v0.1.6

@zhyncs
Copy link
Member Author

zhyncs commented Aug 28, 2024

Nice!

@zhyncs zhyncs force-pushed the gl branch 2 times, most recently from b40c6ab to 7a6f762 Compare August 28, 2024 09:27
@zhyncs zhyncs removed the wip label Aug 28, 2024
@zhyncs zhyncs marked this pull request as ready for review August 28, 2024 10:17
@zhyncs zhyncs force-pushed the gl branch 2 times, most recently from 0e73f52 to a46eb0b Compare August 28, 2024 12:49
@zhyncs
Copy link
Member Author

zhyncs commented Aug 28, 2024

hold on I just test it

@zhyncs zhyncs enabled auto-merge (squash) August 28, 2024 13:45
@zhyncs zhyncs merged commit c411f32 into sgl-project:main Aug 28, 2024
8 checks passed
@zhyncs zhyncs deleted the gl branch August 28, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy merrymercy approved these changes

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@yzh119 yzh119 Awaiting requested review from yzh119

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

Assignees

@zhyncs zhyncs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhyncs @yzh119 @merrymercy