Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor Fix] Fix llava modalities issue for single-image #1402

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

kcz358
Copy link
Contributor

@kcz358 kcz358 commented Sep 12, 2024

Motivation

As described in #1400 , LLaVA is performing worse under single-image evaluation

Modifications

Fix the condition issue when forwarding single-image using llava. Adapt the new modalities parameters with single-image

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@kcz358
Copy link
Contributor Author

kcz358 commented Sep 12, 2024

Alignment result

AI2D

image

MME

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants