Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libibverbs-dev to Dockerfile #1427

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Conversation

Aphoh
Copy link
Contributor

@Aphoh Aphoh commented Sep 15, 2024

Motivation

Currently when running sglang in a multi-node configuration with infiniband and NCCL_DEBUG=INFO, the logs will contain

...
NCCL INFO Failed to open libibverbs.so[.1]
...
NCCL INFO NET/Socket : Using [0]ib0.<ip>
...

This means all-reduces will be performed over TCP instead of gpu RDMA. In the VLLM containers, they fix this by installing libibverbs-dev here

Doing so in sglang's docker container fixes this issue and greatly speeds up multi-node deployments.

Modifications

Add libibverbs-dev to the installed dependencies in the Dockerfile.

Checklist

  • [ x] Format your code according to the Contributor Guide.
  • [x ] Add unit tests as outlined in the Contributor Guide.
  • [x ] Update documentation as needed, including docstrings or example tutorials.

@zhyncs zhyncs enabled auto-merge (squash) September 15, 2024 06:40
@zhyncs zhyncs disabled auto-merge September 15, 2024 06:40
@zhyncs zhyncs merged commit 58cafe2 into sgl-project:main Sep 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants