Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Catch syntax error of Regex Guide to avoid crash #1521

Merged
merged 10 commits into from
Sep 28, 2024

Conversation

du00cs
Copy link
Contributor

@du00cs du00cs commented Sep 26, 2024

Motivation

Invalid regex will lead to an immediate server exit now.
image

(please ignore the first error catch)

Modifications

Catch InvalidSyntax error of interegular, and set the regex guide and jump forward to None.

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@du00cs du00cs changed the title [Fix] Catch syntax error of Regex Guide to avoid crash [FIX] Catch syntax error of Regex Guide to avoid crash Sep 26, 2024
@merrymercy merrymercy enabled auto-merge (squash) September 28, 2024 19:40
@merrymercy merrymercy disabled auto-merge September 28, 2024 19:41
@merrymercy merrymercy merged commit 840c5db into sgl-project:main Sep 28, 2024
2 of 10 checks passed
@du00cs du00cs deleted the catch-syntax-error branch September 29, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants