-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Llama3.2 vision model support #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnyls2002
force-pushed
the
llama-3.2
branch
2 times, most recently
from
October 1, 2024 08:12
00cd46a
to
2aebd9f
Compare
antinucleon
reviewed
Oct 6, 2024
5 tasks
3 tasks
merrymercy
reviewed
Oct 21, 2024
hnyls2002
requested review from
Ying1123,
zhyncs,
ispobock and
ByronHsu
as code owners
October 21, 2024 21:14
hcyz33
reviewed
Dec 4, 2024
@@ -154,7 +160,7 @@ def get_kv_buffer(self, layer_id: int) -> Tuple[torch.Tensor, torch.Tensor]: | |||
|
|||
def set_kv_buffer( | |||
self, | |||
layer_id: int, | |||
layer: RadixAttention, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it necessary to change the data type from int to RadixAttention here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Note that to support CUDA graph for encoder-decoder architecture like llama vision (mllama), we should make
encoder_lens
the part of the cuda graph, as thefull_text_row_masked_out_mask
is decided byencoder_lens
to skip the text-only req in a mixed batch.However, the current cuda graph backend (flashinfer) seems to have trouble handling the mixed batch. So we for now only accept the pure image decoding batch.
Todo in the following PRs:
sliding_window
,single_attention
,cross_attention
Modifications
Checklist