Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify prometheus metrics #1981

Merged
merged 16 commits into from
Nov 10, 2024
Merged

Simplify prometheus metrics #1981

merged 16 commits into from
Nov 10, 2024

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Nov 10, 2024 •
edited
Loading

  • Reduce the overhead of metrics collection.
  • Split the metrics collection into two parts: SchedulerMetricsCollector and TokenizerMetricsCollector
    • metrics such as TTFT, TPOP, prompt_tokens_total, generation_tokens_total are now collected in TokenizerManager.
  • Simplify redundant code. Remove unessential metrics.

@merrymercy merrymercy merged commit 1929c06 into main Nov 10, 2024
1 of 12 checks passed
@merrymercy merrymercy deleted the pr-fix-metrics branch November 10, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merrymercy