[router] add base_gpu_id server args & merged radix tree python reference #2115
+513
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronHsu
requested review from
merrymercy,
Ying1123,
hnyls2002,
zhyncs and
ispobock
as code owners
ByronHsu
changed the title
merrymercy
reviewed
Nov 21, 2024
|
@merrymercy can you take another look? |
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR prepares for #2114 by:
Adding
base_gpu_idserver argument to set the device ID offset when starting TP server. This enables starting multiple TP servers with different base GPU IDs when launching several servers and the router together using a single command. This also eliminates the need of settingCUDA_VISIBLE_DEVICEif we want to launch on certain GPUsAdding merged radix tree Python implementation. This serves as an experimental Python version which I referenced for my Rust implementation.
Modifications
Checklist