Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi SGLang engines to coordinate #2791

Closed
wants to merge 284 commits into from

Conversation

fzyzcjy
Copy link
Collaborator

@fzyzcjy fzyzcjy commented Jan 8, 2025

Motivation

Modifications

  • Refactor related modules (can extract to a separate PR if needed)
  • Implement the new feature (there is an example and a test file to demonstrate)

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

Sorry, something went wrong.

@fzyzcjy fzyzcjy changed the title [WIP] Allow multi SGLang engines to coordinate (another design) Jan 8, 2025
@fzyzcjy fzyzcjy changed the title Allow multi SGLang engines to coordinate (another design) Allow multi SGLang engines to coordinate Jan 8, 2025
@fzyzcjy fzyzcjy marked this pull request as ready for review January 8, 2025 13:19
# Conflicts:
#	python/sglang/srt/managers/tokenizer_manager.py
# Conflicts:
#	python/sglang/srt/managers/tokenizer_manager.py
# Conflicts:
#	python/sglang/srt/managers/tokenizer_manager.py
# Conflicts:
#	python/sglang/srt/managers/detokenizer_manager.py
#	python/sglang/srt/managers/tokenizer_manager.py
@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Jan 25, 2025

Given how previous PR is separated into smaller PRs to enable easier merging and reviewing, this PR is also separated into multiple smaller PRs.

@fzyzcjy fzyzcjy closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant