Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement served_model_name to customize model id when use local mode… #749

Merged
merged 3 commits into from
Aug 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/sglang/srt/managers/tokenizer_manager.py
Original file line number Diff line number Diff line change
@@ -79,6 +79,7 @@ def __init__(
self.send_to_router.connect(f"tcp://127.0.0.1:{port_args.controller_port}")

self.model_path = server_args.model_path
self.served_model_name = server_args.served_model_name
self.hf_config = get_config(
self.model_path,
trust_remote_code=server_args.trust_remote_code,
6 changes: 3 additions & 3 deletions python/sglang/srt/server.py
Original file line number Diff line number Diff line change
@@ -190,10 +190,10 @@ async def retrieve_file_content(file_id: str):
@app.get("/v1/models")
def available_models():
"""Show available models."""
model_names = [tokenizer_manager.model_path]
served_model_names = [tokenizer_manager.served_model_name]
model_cards = []
for model_name in model_names:
model_cards.append(ModelCard(id=model_name, root=model_name))
for served_model_name in served_model_names:
model_cards.append(ModelCard(id=served_model_name, root=served_model_name))
return ModelList(data=model_cards)


11 changes: 11 additions & 0 deletions python/sglang/srt/server_args.py
Original file line number Diff line number Diff line change
@@ -32,6 +32,7 @@ class ServerArgs:
trust_remote_code: bool = True
context_length: Optional[int] = None
quantization: Optional[str] = None
served_model_name: Optional[str] = None
chat_template: Optional[str] = None

# Port
@@ -90,6 +91,10 @@ class ServerArgs:
def __post_init__(self):
if self.tokenizer_path is None:
self.tokenizer_path = self.model_path

if self.served_model_name is None:
self.served_model_name = self.model_path

if self.mem_fraction_static is None:
if self.tp_size >= 16:
self.mem_fraction_static = 0.79
@@ -202,6 +207,12 @@ def add_cli_args(parser: argparse.ArgumentParser):
],
help="The quantization method.",
)
parser.add_argument(
"--served-model-name",
type=str,
default=ServerArgs.served_model_name,
help="Override the model name returned by the v1/models endpoint in OpenAI API server.",
)
parser.add_argument(
"--chat-template",
type=str,