Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32 error: narrowing conversion of negative chars #4

Open
hpsaturn opened this issue Jun 21, 2024 · 2 comments
Open

ESP32 error: narrowing conversion of negative chars #4

hpsaturn opened this issue Jun 21, 2024 · 2 comments

Comments

@hpsaturn
Copy link
Contributor

On ESP32 we have the next issue:

 tests/lib/starmaplib/src/arrays.cpp:153:7: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
hpsaturn added a commit to hpsaturn/starmap that referenced this issue Jun 21, 2024
@hpsaturn
it fixes the issue shabaz123#4
89a32b4
@hpsaturn hpsaturn mentioned this issue Jun 21, 2024
Merged
@hpsaturn
Copy link
Contributor Author

I added an untested PR with a possible fix. Right now is compiling ok using the esp32s3 env with PlatformIO

shabaz123 added a commit that referenced this issue Jun 21, 2024
@shabaz123
Merge pull request #5 from hpsaturn/fix_esp32_compile_issue
1648003 
fix the issue #4
@shabaz123
Copy link
Owner

Closing for now since we have the #ifdef solution for ESP32, and the -Wno-narrowing for Pi Pico. But probably the issue will occur for other platforms/build environments so longer-term it would be good to resolve it without these workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hpsaturn @shabaz123