-
-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Libs] Ngs2 #1604
base: main
Are you sure you want to change the base?
[Libs] Ngs2 #1604
Conversation
Is this supposed to work yet? I tried with Resident Evil and it crashes when calling the module
|
First off, let me state that audio in GR2 is a bit broken, and needs a skipped assert to get ingame, so it's possible that the problem comes from that, and not your PR. Without the Ngs2 sysmodule, GR2 does output any sound, and with that on, the audio is way too loud and loopy. Here's a video showcasing it. As the game does not go ingame on the latest main yet, I merged this PR on my gr2-hacks branch to test it. It segfaults a few seconds into booting, with the following stack trace: shadPS4/src/core/libraries/ngs2/ngs2_impl.cpp Line 135 in 8d7d781
called from here: shadPS4/src/core/libraries/ngs2/ngs2.cpp Line 192 in 8d7d781
called from the game code. I'll attach the log as well, with the last few lines manually copied over from the terminal, as those lines got printed out to there, but not in the log. |
ngs2_impl
to be more accurate, including structs (with byte comments, need confirmation)I can remove the
.cpp
or.h
that are not used or empty if needed.