renderer_vulkan: Cleanup and improve barriers in caches #1865
+190
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Batch image and buffer barriers in a single command
mikusp
reviewed
Dec 24, 2024
| const vk::BufferMemoryBarrier2 buf_barrier = { | ||
| const vk::BufferMemoryBarrier2 pre_barrier = { | ||
| .srcStageMask = vk::PipelineStageFlagBits2::eAllCommands, | ||
| .srcAccessMask = vk::AccessFlagBits2::eMemoryRead, |
There was a problem hiding this comment.
Reads in the srcAccessMask are a no-op according to Vulkan spec https://stackoverflow.com/a/64757475 KhronosGroup/Vulkan-Docs#131
There was a problem hiding this comment.
Hmm correct, so either need to guard for writes or make this eNone
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
Jan 3, 2025
…ps4-emu#1865)" This reverts commit 77d2172.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes some barriers more strict to solve sync validation warnings