renderer: treat disabled viewport as render area #1906
Closed
+37
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
it does fix Fist of the North Star |
Co-authored-by: IndecisiveTurtle <[email protected]>
roamic
force-pushed
the
fix-disabled-viewport
branch
from
a589f82 to
8e944f9
Compare
|
Turned out to be incorrect. In FotNS:LP affected VS does not output coordinates in clip space, it outputs coordinates directly in window space, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason this helps Fist of the North Star and Yakuza 5. Will remain a draft until I figure out if this is correct.