Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storing encryption trophy key in config.toml #1930

Merged
merged 9 commits into from
Jan 1, 2025
Merged

Storing encryption trophy key in config.toml #1930

merged 9 commits into from
Jan 1, 2025

Conversation

georgemoralis
Copy link
Collaborator

This will store the trophy key into configuration file .

@georgemoralis georgemoralis marked this pull request as draft December 27, 2024 20:18
@georgemoralis georgemoralis marked this pull request as ready for review December 28, 2024 10:59
polybiusproxy
polybiusproxy approved these changes Dec 28, 2024
View reviewed changes
Copy link
Collaborator

@polybiusproxy polybiusproxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, but ideally, we would want to handle decryption failure if no key is provided.

ngoquang2708
ngoquang2708 reviewed Dec 28, 2024
View reviewed changes
src/common/config.cpp Outdated Show resolved Hide resolved
@ngoquang2708
Copy link
Contributor

You can use boost::algorithm::unhex() to decode the hex string.

@georgemoralis georgemoralis merged commit 283442b into shadps4-emu:main Jan 1, 2025
10 checks passed
@georgemoralis georgemoralis deleted the keys branch January 1, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoquang2708 ngoquang2708 ngoquang2708 left review comments

@polybiusproxy polybiusproxy polybiusproxy approved these changes

@raphaelthegreat raphaelthegreat Awaiting requested review from raphaelthegreat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgemoralis @ngoquang2708 @polybiusproxy