Posix Net #1956
Posix Net #1956
Conversation
src/core/libraries/kernel/net.cpp
Outdated
| return 0; | ||
| } | ||
| u32 PS4_SYSV_ABI posix_htonl(u32 hostlong) { | ||
| return htonl(hostlong); |
There was a problem hiding this comment.
may you add ::, for global scope, like ::htonl. it shows we use native OS functions
src/core/libraries/kernel/net.cpp
Outdated
| return htons(hostshort); | ||
| } | ||
| int PS4_SYSV_ABI posix_bind(int sockfd, const struct sockaddr* addr, socklen_t addrlen) { | ||
| return 0; |
There was a problem hiding this comment.
i think, no need such stubbed funcs leave silent, at least, add LOG_TRACE, or LOG_DEBUG, for info
There was a problem hiding this comment.
oh it is still in progress will have logging soon
src/core/libraries/kernel/net.h
Outdated
|
|
||
| namespace Libraries::Kernel { | ||
| int PS4_SYSV_ABI posix_socket(int domain, int type, int protocol); | ||
| int PS4_SYSV_ABI posix_connect(int sockfd, const struct sockaddr* addr, socklen_t addrlen); |
There was a problem hiding this comment.
i am not sure, if struct sockaddr is crossplarform, maybe explicit use OrbisNetSockaddr, and convert to win/mac/linux sockaddr inside?
do not remember if these structs equals
georgemoralis
force-pushed
the
net
branch
5 times, most recently
from
4e72784 to
bad2b88
Compare
|
peggle2 seems to work here |
|
Can maybe fix this game also: |
|
@georgemoralis As someone with an interest in Peggle 2 running, could you say why was this PR closed? |
|
@georgemoralis was testing Peggle and he lost so he closed the PR out of anger |
Very initial , just for view