Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: Improve port state guards. #1998

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

squidbus
Copy link
Collaborator

Upgraded the output mutex of ports to a full port state mutex, updated port uses to hold this mutex, and added guards against port invalidation during port conditional variable waits.

Also, added some additional logging for the SDL audio stream buffer sizes and queue threshold.

@squidbus squidbus changed the title Out state audio: Improve port state guards. Dec 31, 2024
@squidbus squidbus marked this pull request as draft December 31, 2024 23:45
@squidbus
Copy link
Collaborator Author

squidbus commented Jan 2, 2025

@Emulator-Team-2 Please retest with Naruto with the latest changes.

@Emulator-Team-2
Copy link
Contributor

Emulator-Team-2 commented Jan 2, 2025

Edit:
The issue is fixed in the latest main build.

@squidbus
The game still freezes on the intro video.

Log:
shad_log.zip

@polybiusproxy
Copy link
Collaborator

polybiusproxy commented Jan 2, 2025

Gran Turismo Sport still freezes on boot since #1986.

@squidbus
Copy link
Collaborator Author

squidbus commented Jan 2, 2025

Pulled in fix from main, cleaned up a bit, should be ready.

@squidbus squidbus marked this pull request as ready for review January 2, 2025 13:40
Copy link
Collaborator

@polybiusproxy polybiusproxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@georgemoralis georgemoralis merged commit 55b5017 into shadps4-emu:main Jan 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants