Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnmdriver: Implement neo mode differences. #2011

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

squidbus
Copy link
Collaborator

@squidbus squidbus commented Jan 1, 2025

Implements Neo mode differences for gnmdriver. Init sequences have a few differences, and a few command buffer writes have changed. For example, IA_MULTI_VGT_PARAM is now (conditionally) used as a uconfig register instead of context, and many draws have a bit added to the command from the flags.

All init sequences have been verified to equal that of the real gnm driver using both regular and neo modes, both with and without an extra ioctl condition passing.

Draft for now because there's still two ioctl based conditions I don't know the meaning of, currently using bool constants.

@squidbus squidbus marked this pull request as draft January 1, 2025 19:51
@squidbus squidbus marked this pull request as ready for review January 2, 2025 23:21
@squidbus
Copy link
Collaborator Author

squidbus commented Jan 2, 2025

As far as I can tell the ioctl condition should be constant for retail consoles but I've left the other init sequences path in gated behind a constant in case we need it in the future. Should be ready for review.

@psucien psucien merged commit 9434cae into shadps4-emu:main Jan 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants