fix: Fix UITextDisplayer desync & null pointer exception (#7199)

Fixes bugs introduced in #6985
shaka-project · Aug 23, 2024 · 247753d · 247753d
1 parent fd5b09c
commit 247753d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/player.js b/lib/player.js
@@ -2371,6 +2371,7 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
           'Text displayer should have a "configure" method!');
     }
     this.lastTextFactory_ = textDisplayerFactory;
+    this.textDisplayer_.setTextVisibility(this.isTextVisible_);
   }
 
   /**
@@ -4083,7 +4084,9 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
         }
         this.textDisplayer_.setTextVisibility(oldDisplayer.isTextVisible());
         oldDisplayer.destroy();
-        this.mediaSourceEngine_.setTextDisplayer(this.textDisplayer_);
+        if (this.mediaSourceEngine_) {
+          this.mediaSourceEngine_.setTextDisplayer(this.textDisplayer_);
+        }
         this.lastTextFactory_ = textDisplayerFactory;
 
         if (this.streamingEngine_) {