Skip to content

Commit

Permalink
chore: Remove the term "blacklist"
Browse files Browse the repository at this point in the history
The term "blacklist" violates new Google guidelines about respectful
language.  This removes all instances of this term in our repo and
replaces them with "denylist".

Bug: 178203011

Change-Id: I90b19a2a8c5382bb36855c8f310b64e85c48c562
  • Loading branch information
joeyparrish committed Feb 1, 2021
1 parent 7544670 commit 2634bc9
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ module.exports = {
'array-bracket-newline': ['error', 'consistent'],
'block-spacing': ['error', 'always'],
'brace-style': ['error', '1tbs', {'allowSingleLine': true}],
'id-blacklist': ['error', 'async'],
'id-denylist': ['error', 'async'],
'lines-between-class-members': 'error',
'max-statements-per-line': ['error', {'max': 1}],
'new-parens': 'error',
Expand Down
2 changes: 1 addition & 1 deletion demo/load.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function shakaUncompiledModeSupported() {
script.defer = true;
// Setting async = false is important to make sure the script is imported
// before the 'load' event fires.
script.async = false; // eslint-disable-line id-blacklist
script.async = false; // eslint-disable-line id-denylist
document.head.appendChild(script);

// Signal success, or else the Closure Library's loader will not load the
Expand Down
17 changes: 0 additions & 17 deletions docs/design/offline.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,23 +137,6 @@ store a stream created by `StreamGenerator` and verify that the `StoredContent`
structure is correct. A test should also load the stored data and verify that
it matches the generated segments.

We should use a subset of IndexedDB supported by IE/Edge. Note the "partial
support" link on [caniuse]. Since the unsupported features seem to be about
key-based arrays and compound indexes, we should be able to easily avoid those.
Integration tests should help ensure that we are doing this correctly.

Also note [caniuse]'s mention of bugs in Safari's IndexedDB implementation,
detailed in [this blog post]. It is not clear yet if the Safari bugs are on iOS
only or also on desktop. We may be forced to blacklist offline support as we
did with Safari 8 in `MediaSourceEngine.support()`. If the bugs have been fixed
in Safari 9 or don't affect desktop, we should be fine. If the bugs do affect
Safari 9 desktop, we could consider working around them. The workaround seems
to be to avoid autoincrement and to constructing string IDs for each object
which are unique across all object stores.

[caniuse]: http://caniuse.com/#feat=indexeddb
[this blog post]: https://www.raymondcamden.com/2014/09/25/IndexedDB-on-iOS-8-Broken-Bad/


#### Error conditions

Expand Down
2 changes: 1 addition & 1 deletion karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ function allUsableBrowserLaunchers(config) {
// Most launchers requiring configuration through customLaunchers have
// no DEFAULT_CMD. Some launchers have DEFAULT_CMD, but not for this
// platform. Finally, WebDriver has DEFAULT_CMD, but still requires
// configuration, so we simply blacklist it by name.
// configuration, so we simply reject it by name.
// eslint-disable-next-line no-restricted-syntax
const DEFAULT_CMD = pluginConstructor.prototype.DEFAULT_CMD;
if (!DEFAULT_CMD || !DEFAULT_CMD[process.platform]) {
Expand Down

0 comments on commit 2634bc9

Please sign in to comment.