Skip to content

Commit

Permalink
Wrong pixelAspectRatio population in DASH (#2614)
Browse files Browse the repository at this point in the history
The current implementation of pixelAspectRatio in DASH is wrong. `@par` in DASH is "picture  aspect ratio" so the correct is populate this field with `@sar`.

Backported to v2.5.x

Change-Id: I5e492e17cee3895af43782b6799e09baa31cffcb
  • Loading branch information
Álvaro Velad Galván authored and joeyparrish committed Jun 10, 2020
1 parent d5e34a3 commit 283faaa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/dash/dash_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -1438,7 +1438,7 @@ shaka.dash.DashParser.prototype.createFrame_ = function(
let frameRate =
XmlUtils.parseAttr(elem, 'frameRate', evalDivision) || parent.frameRate;
const pixelAspectRatio =
elem.getAttribute('par') || parent.pixelAspectRatio;
elem.getAttribute('sar') || parent.pixelAspectRatio;
let emsgSchemeIdUris = this.emsgSchemeIdUris_(
XmlUtils.findChildren(elem, 'InbandEventStream'),
parent.emsgSchemeIdUris);
Expand Down

0 comments on commit 283faaa

Please sign in to comment.