address feedback

shaka-project · May 3, 2023 · 4c12557 · 4c12557
1 parent da8d3b2
commit 4c12557
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 18 deletions.
diff --git a/lib/util/mime_utils.js b/lib/util/mime_utils.js
@@ -25,12 +25,8 @@ shaka.util.MimeUtils = class {
    */
   static getFullType(mimeType, codecs) {
     let fullMimeType = mimeType;
-    if (codecs) {
-      if (!shaka.util.MimeUtils.RAW_FORMATS.includes(mimeType)) {
-        fullMimeType += '; codecs="' + codecs + '"';
-      } else {
-        fullMimeType += '; codecs=""';
-      }
+    if (codecs && !shaka.util.MimeUtils.RAW_FORMATS.includes(mimeType)) {
+      fullMimeType += '; codecs="' + codecs + '"';
     }
     return fullMimeType;
   }
@@ -99,7 +95,6 @@ shaka.util.MimeUtils = class {
       if (streamKey == 'codecs' &&
           shaka.util.MimeUtils.RAW_FORMATS.includes(stream.mimeType)) {
         // Skip codecs for raw formats
-        components.push(mimeKey + '=""');
       } else if (value) {
         components.push(mimeKey + '="' + value + '"');
       }

diff --git a/test/player_integration.js b/test/player_integration.js
@@ -592,17 +592,6 @@ describe('Player', () => {
       await waiter.waitUntilPlayheadReachesOrFailOnTimeout(video, 1, 10);
     });
 
-    it('with containerless formats', async () => {
-      player = new compiledShaka.Player(video);
-      // eslint-disable-next-line max-len
-      const url = 'https://storage.googleapis.com/shaka-demo-assets/raw-hls-audio-only/manifest.m3u8';
-      await player.load(url, 0);
-
-      // Ensure the video plays.
-      video.play();
-      await waiter.waitUntilPlayheadReachesOrFailOnTimeout(video, 5, 15);
-    });
-
     /**
      * Gets the language of the active Variant.
      * @return {string}