Skip to content

Commit

Permalink
Remove invalid assertion.
Browse files Browse the repository at this point in the history
If a user seeks while an update is in progress,
waitingToClearBuffer can be set to true. When that update
finishes, performingUpdate will be set to false. So, if the user
seeks again before onUpdate_ is called, waitingToClearBuffer
can be true and performingUpdate will be false, thus, the
assertion in seeked() is not valid.

Closes #334

Change-Id: Id6517078bf0e9037ead2d357c4db241f381a383c
  • Loading branch information
Timothy Drews committed Apr 19, 2016
1 parent 7c1e7ea commit 59fb136
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/media/streaming_engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -473,11 +473,7 @@ shaka.media.StreamingEngine.prototype.seeked = function() {
// clear the buffer.

if (mediaState.waitingToClearBuffer) {
// The only reason we should be waiting to clear the buffer is if we're
// performing an update.
shaka.log.debug(logPrefix, 'seeked: unbuffered seek: already waiting');
goog.asserts.assert(mediaState.performingUpdate,
'expected performingUpdate to be true');
continue;
}

Expand Down

0 comments on commit 59fb136

Please sign in to comment.