Skip to content

Commit

Permalink
docs: Fixed outdated info and typos (#3206)
Browse files Browse the repository at this point in the history
Change-Id: I358806b67de5b26e3e03cb092c9e451fe1cfdbf5
  • Loading branch information
idontknowjs authored and joeyparrish committed Mar 12, 2021
1 parent 06d83a0 commit 5e8ba28
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 9 deletions.
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ just a few small guidelines you need to follow.

1. File a bug at https://github.com/google/shaka-player/issues (if there isn't
one already). If your patch is going to be large, you should start a
discussion on the mailing list first to make sure it is in line with our
design.
discussion on GitHub first.

2. For legal reasons, all contributors must sign a Contributor License
Agreement, either for an individual or corporation, before a patch can be
Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/ad_monetization.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ adManager.addEventListener(shaka.ads.AdManager.AD_STARTED, (e) => {

[full list of ad events]: https://shaka-player-demo.appspot.com/docs/api/shaka.ads.AdManager.html#.event:AdBreakReadyEvent

#### Accomodating IMA Power Users
#### Accommodating IMA Power Users
If you have an existing IMA integration you want to plug into Shaka, or you want
to use more intricate SDK capabilities not exposed through our API, we provide a
way to do that.
Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ group file. For example:
-@networking
# Add my custom HTTP implementation
+/path/to/my_http_plugin.js
# Add an additional polyfill for some odd platform I'm targetting
# Add an additional polyfill for some odd platform I'm targeting
+/path/to/my_platform_polyfill.js
```

Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/ui-customization.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ ui.configure(config);
An important note: the 'overflow_menu' button needs to be part of the 'controlPanelElements'
layout for the overflow menu to be available to the user.

The presense of the seek bar and the big play button in the center of the video element can be
The presence of the seek bar and the big play button in the center of the video element can be
customized with `addSeekBar` and `addBigPlayButton` booleans in the config.

UI layout can be reconfigured at any point after it's been created.
Expand Down
4 changes: 2 additions & 2 deletions docs/tutorials/upgrade-v2-4.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ The config field `manifest.dash.defaultPresentationDelay` has been moved to
v4.0. Applications using this field SHOULD update to use the new location.
The `manifest.defaultPresentationDelay` field now affects both DASH and HLS
content. The default value is `0`, which is interpretted differently for DASH
content. The default value is `0`, which is interpreted differently for DASH
and HLS:
- In DASH, `0` means a default of `1.5 * minBufferTime`.
Expand Down Expand Up @@ -423,7 +423,7 @@ The `Cue` objects consumed by `TextDisplayer` have changed in v2.5 and v3.0.
- `Cue.writingDirection` has been split into `Cue.writingMode` and
`Cue.direction` to fix bugs in the handling of these attributes
- `Cue.size` now defaults to `0`, which should be interpretted as "auto" (fit
- `Cue.size` now defaults to `0`, which should be interpreted as "auto" (fit
to text).
All application-specific TextDisplayer plugins MUST be updated.
Expand Down
4 changes: 2 additions & 2 deletions docs/tutorials/upgrade-v2-5.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ The config field `manifest.dash.defaultPresentationDelay` has been moved to
v4.0. Applications using this field SHOULD update to use the new location.

The `manifest.defaultPresentationDelay` field now affects both DASH and HLS
content. The default value is `0`, which is interpretted differently for DASH
content. The default value is `0`, which is interpreted differently for DASH
and HLS:

- In DASH, `0` means a default of `1.5 * minBufferTime`.
Expand Down Expand Up @@ -359,7 +359,7 @@ See {@link shaka.extern.AbrManager} for details.

The `Cue` objects consumed by `TextDisplayer` have changed in v3.0.

- `Cue.size` now defaults to `0`, which should be interpretted as "auto" (fit
- `Cue.size` now defaults to `0`, which should be interpreted as "auto" (fit
to text).

All application-specific TextDisplayer plugins MUST be updated.
Expand Down

0 comments on commit 5e8ba28

Please sign in to comment.