Skip to content

Commit

Permalink
Skip tests on Edge and Tizen
Browse files Browse the repository at this point in the history
  • Loading branch information
avelad committed Jun 22, 2023
1 parent c07ac10 commit 6d1775a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/util/platform.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,10 @@ shaka.util.Platform = class {
* @return {boolean}
*/
static isChrome() {
// The Edge user agent will also contain the "Chrome" keyword, so we need
// to make sure this is not Edge.
// The Edge Legacy user agent will also contain the "Chrome" keyword, so we
// need to make sure this is not Edge Legacy.
return shaka.util.Platform.userAgentContains_('Chrome') &&
!shaka.util.Platform.isEdge();
!shaka.util.Platform.isLegacyEdge();
}

/**
Expand Down
14 changes: 14 additions & 0 deletions test/transmuxer/transmuxer_integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,20 @@ describe('Transmuxer Player', () => {
if (!MediaSource.isTypeSupported('audio/mp4; codecs="ac-3"')) {
return;
}
// This tests is flaky in some Tizen devices, so we need omit it for now.
if (shaka.util.Platform.isTizen()) {
return;
}
// It seems that AC3 on Edge Windows from github actions is not working
// (in the lab AC3 is working). The AC3 detection is currently hard-coded
// to true, which leads to a failure in GitHub's environment.
// We must enable this, once it is resolved:
// https://bugs.chromium.org/p/chromium/issues/detail?id=1450313
if (shaka.util.Platform.isEdge() &&
shaka.util.Platform.chromeVersion() <= 116) {
return;
}

// eslint-disable-next-line max-len
const url = 'https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/a2/prog_index.m3u8';

Expand Down

0 comments on commit 6d1775a

Please sign in to comment.