feat(cea): Add CEA parser for TS

shaka-project · Nov 15, 2022 · 7b0e83f · 7b0e83f
1 parent eaa5631
commit 7b0e83f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/media/media_source_engine.js b/lib/media/media_source_engine.js
@@ -580,6 +580,8 @@ shaka.media.MediaSourceEngine = class {
       return;
     }
 
+    let timestampOffset = this.sourceBuffers_[contentType].timestampOffset;
+
     const uint8ArrayData = shaka.util.BufferUtils.toUint8(data);
     let mimeType = this.sourceBufferTypes_[contentType];
     if (this.transmuxers_[contentType]) {
@@ -590,7 +592,7 @@ shaka.media.MediaSourceEngine = class {
       // The SourceBuffer timestampOffset may or may not be set yet, so this is
       // the timestamp offset that would eventually compute for this segment
       // either way.
-      const timestampOffset =
+      timestampOffset =
           reference.startTime - (tsParser.getStartTime()[contentType] || 0);
       const metadata = tsParser.getMetadata();
       if (metadata.length) {
@@ -627,13 +629,11 @@ shaka.media.MediaSourceEngine = class {
       } else {
         const closedCaptions = this.captionParser_.parseFrom(data);
         if (closedCaptions.length) {
-          const videoOffset =
-            this.sourceBuffers_[ContentType.VIDEO].timestampOffset;
           this.textEngine_.storeAndAppendClosedCaptions(
               closedCaptions,
               reference.startTime,
               reference.endTime,
-              videoOffset);
+              timestampOffset);
         }
       }
     }

diff --git a/test/media/media_source_engine_integration.js b/test/media/media_source_engine_integration.js
@@ -396,7 +396,7 @@ describe('MediaSourceEngine', () => {
     mediaSourceEngine.setSelectedClosedCaptionId('CC1');
     await appendWithClosedCaptions(ContentType.VIDEO, 0);
 
-    expect(textDisplayer.appendSpy).toHaveBeenCalledTimes(3);
+    expect(textDisplayer.appendSpy).toHaveBeenCalledTimes(2);
   });
 
   it('extracts CEA-708 captions from previous segment from hls', async () => {