Skip to content

Commit

Permalink
Rename Timeline events to include the "Event" suffix (#1267)
Browse files Browse the repository at this point in the history
Right now, the timeline related events are the only events defined without an "Event"-suffix in the name. Their naming should follow the naming used throughout the rest of the project.
  • Loading branch information
niklaskorz authored and joeyparrish committed Feb 1, 2018
1 parent 554cffc commit 7c18e08
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# Please keep the list sorted.

AdsWizz <*@adswizz.com>
Alugha GmbH <*@alugha.com>
Bonnier Broadcasting <*@bonnierbroadcasting.com>
Bryan Huh <[email protected]>
Esteban Dosztal <[email protected]>
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ Mattias Wadman <[email protected]>
Michelle Zhuo <[email protected]>
Natalie Harris <[email protected]>
Nick Desaulniers <[email protected]>
Niklas Korz <[email protected]>
Oskar Arvidsson <[email protected]>
Robert Colantuoni <[email protected]>
Rohit Makasana <[email protected]>
Expand Down
6 changes: 3 additions & 3 deletions lib/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ shaka.Player.version = 'v2.3.0-uncompiled';


/**
* @event shaka.Player.TimelineRegionAdded
* @event shaka.Player.TimelineRegionAddedEvent
* @description Fired when a media timeline region is added.
* @property {string} type
* 'timelineregionadded'
Expand All @@ -300,7 +300,7 @@ shaka.Player.version = 'v2.3.0-uncompiled';


/**
* @event shaka.Player.TimelineRegionEnter
* @event shaka.Player.TimelineRegionEnterEvent
* @description Fired when the playhead enters a timeline region.
* @property {string} type
* 'timelineregionenter'
Expand All @@ -311,7 +311,7 @@ shaka.Player.version = 'v2.3.0-uncompiled';


/**
* @event shaka.Player.TimelineRegionExit
* @event shaka.Player.TimelineRegionExitEvent
* @description Fired when the playhead exits a timeline region.
* @property {string} type
* 'timelineregionexit'
Expand Down

0 comments on commit 7c18e08

Please sign in to comment.