Skip to content

Commit

Permalink
Add preferred audio channel config field to demo
Browse files Browse the repository at this point in the history
Issue #1013

Change-Id: I55cf86bd7b41d98155a4b4346277869cb4baa15c
  • Loading branch information
joeyparrish committed Apr 16, 2018
1 parent ff082ee commit c13ac1f
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 1 deletion.
6 changes: 6 additions & 0 deletions demo/asset_section.js
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,12 @@ shakaDemo.preparePlayer_ = function(asset) {
document.getElementById('preferredAudioLanguage').value;
config.preferredTextLanguage =
document.getElementById('preferredTextLanguage').value;
const preferredAudioChannelCount =
document.getElementById('preferredAudioChannelCount').valueAsNumber;
if (!isNaN(preferredAudioChannelCount)) {
config.preferredAudioChannelCount = preferredAudioChannelCount;
}

config.abr.enabled =
document.getElementById('enableAdaptation').checked;
let smallGapLimit = document.getElementById('smallGapLimit').value;
Expand Down
6 changes: 5 additions & 1 deletion demo/configuration_section.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ shakaDemo.setupConfiguration_ = function() {
'input', shakaDemo.onConfigInput_);
document.getElementById('preferredTextLanguage').addEventListener(
'input', shakaDemo.onConfigInput_);
document.getElementById('preferredAudioChannelCount').addEventListener(
'input', shakaDemo.onConfigInput_);
document.getElementById('showNative').addEventListener(
'change', shakaDemo.onNativeChange_);
document.getElementById('showTrickPlay').addEventListener(
Expand Down Expand Up @@ -152,7 +154,9 @@ shakaDemo.onConfigInput_ = function(event) {
preferredAudioLanguage:
document.getElementById('preferredAudioLanguage').value,
preferredTextLanguage:
document.getElementById('preferredTextLanguage').value
document.getElementById('preferredTextLanguage').value,
preferredAudioChannelCount:
document.getElementById('preferredAudioChannelCount').value,
}));
// Change the hash, to mirror this.
shakaDemo.hashShouldChange_();
Expand Down
3 changes: 3 additions & 0 deletions demo/demo.css
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,12 @@ h1 {
padding: 0 0 0.2em 0;
}

input[type=number],
input[type=text] {
font-family: Roboto, sans-serif;
font-size: 0.9em;
padding: 1px 2px 3px 6px;
height: 19px;
}

label, .label {
Expand Down Expand Up @@ -358,6 +360,7 @@ summary {
font-size: 1.4em;
}

input[type=number],
input[type=text] {
font-size: 0.8em;
}
Expand Down
4 changes: 4 additions & 0 deletions demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ <h1>Shaka Player <span id="version"></span></h1>
<label for="preferredTextLanguage">Preferred text language:</label>
<input id="preferredTextLanguage" class="flex-grow" type="text">
</div>
<div class="flex">
<label for="preferredAudioChannelCount">Preferred audio channel count:</label>
<input id="preferredAudioChannelCount" type="number">
</div>
<div>
<label for="showNative">Show native browser controls:</label>
<input id="showNative" type="checkbox">
Expand Down
10 changes: 10 additions & 0 deletions demo/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ shakaDemo.init = function() {
document.getElementById('preferredAudioLanguage').value = language;
document.getElementById('preferredTextLanguage').value = language;

document.getElementById('preferredAudioChannelCount').value = '2';

let params = shakaDemo.getParams_();

shakaDemo.setupLogging_();
Expand Down Expand Up @@ -273,6 +275,10 @@ shakaDemo.preBrowserCheckParams_ = function(params) {
if ('textlang' in params) {
document.getElementById('preferredTextLanguage').value = params['textlang'];
}
if ('channels' in params) {
document.getElementById('preferredAudioChannelCount').value =
params['channels'];
}
if ('asset' in params) {
document.getElementById('manifestInput').value = params['asset'];
}
Expand Down Expand Up @@ -522,6 +528,10 @@ shakaDemo.hashShouldChange_ = function() {
} else {
params.push('lang=' + audioLang);
}
let channels = document.getElementById('preferredAudioChannelCount').value;
if (channels != '2') {
params.push('channels=' + channels);
}
if (document.getElementById('logToScreen').checked) {
params.push('logtoscreen');
}
Expand Down

0 comments on commit c13ac1f

Please sign in to comment.