fix(ui): Avoid submitting form if player is inside form (#4866)

`button` element by default has `type` set to `submit` which can interfere with forms. Fixes #4861
shaka-project · Jan 3, 2023 · da21850 · da21850
1 parent 5681efe
commit da21850
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/util/dom_utils.js b/lib/util/dom_utils.js
@@ -36,7 +36,9 @@ shaka.util.Dom = class {
    * @return {!HTMLButtonElement}
    */
   static createButton() {
-    return /** @type {!HTMLButtonElement} */(document.createElement('button'));
+    const button = document.createElement('button');
+    button.setAttribute('type', 'button');
+    return /** @type {!HTMLButtonElement} */ (button);
   }