Skip to content

Commit

Permalink
Adding hard-coded minBufferTime to offline playback. Issue #22.
Browse files Browse the repository at this point in the history
minBufferTime is hard-coded when reconstructing manifestInfo
from offline. This is needed to prevent failing assertions
during playback. 5 was chosen because it is large enough to
keep playback going properly and small enough that the buffered
data won't get garbage collected.

Change-Id: Iabb08137bda95d15f35a5e5f6386c0be321de7fa
  • Loading branch information
natalieharris authored and joeyparrish committed May 22, 2015
1 parent 27260cc commit eeaafe9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/player/offline_video_source.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ shaka.player.OfflineVideoSource.prototype.load = function(preferredLanguage) {
shaka.player.OfflineVideoSource.prototype.reconstructManifestInfo_ =
function(indexes, duration, keySystem) {
var manifestInfo = new shaka.media.ManifestInfo();
manifestInfo.minBufferTime = 5;
// TODO(story 1890046): Support multiple periods.
var periodInfo = new shaka.media.PeriodInfo();

Expand Down

0 comments on commit eeaafe9

Please sign in to comment.