-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support muxed video+audio with URI-less EXT-X-MEDIA tag #1086
Comments
We were not aware of this issue, and we must have overlooked this in the spec. I've tentatively scheduled for v2.4. To help us plan the work and understand the issue better, can you please provide sample content which is currently failing due to this issue? If you can't post a URL publicly, please email to [email protected] instead. Thanks! |
Hi @joeyparrish , Thanks for responding the issue so quickly, I have sent the testing stream via email. Please let me know if there is anything I can help. |
Ah, I see now. So without the URI attribute in the EXT-X-MEDIA audio tag, the audio is muxed in with the video. Is that correct? |
@joeyparrish Yes, you are totally correct! |
We have the same problem. Flussonic (major video streaming software) generates playlists with audio tracks URI, except of the default:
It would be nice if shaka could handle this. |
The commit message in adde0bd is malformed, but this issue was fixed by that commit. |
Fix cherry-picked for v2.4.6. |
Based on the HLS spec
There is a missing logic in Shaka-player HLS parser which is the URI attribute should be optional if the media type is VIDEO or AUDIO. Current Shaka-player(version:2.2.4) sees them are all REQUIRED.
Please let me know if the above statements are true. If it's true, is there any plan to add this missing logic to the HLS parser? I might be able to help for creating PR for this. Thanks!
The text was updated successfully, but these errors were encountered: