Demo app's URL hash doesn't change in Edge since v2.2.3 #1111
Assignees
Labels
flag: Why didn't we catch this sooner
This issue is embarassing; we may still need an automated test that could have prevented this issue
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
joeyparrish
added
the
flag: Why didn't we catch this sooner
shaka-bot
pushed a commit
that referenced
this issue
Dec 4, 2017
Sometimes, on IE 11, the demo app fails to load because "shaka" is undefined when shakaDemo.init() is called. This seems to have been introduced in 5126324 when we started deferring script loading. This bug has not appeared in a release version yet. It seems that IE 11 sets the readyState on the document at the wrong time when scripts are deferred. Edge and Chrome both do the right thing. This came up during debugging while working on #1111, but this fix is not part of the fix for #1111. Change-Id: Ia42466acdced7ca67fed5a6e8270620b7d8dcd50
|
Fix cherry-picked for v2.2.8. |
joeyparrish
added a commit
that referenced
this issue
Dec 5, 2017
Sometimes, on IE 11, the demo app fails to load because "shaka" is undefined when shakaDemo.init() is called. This seems to have been introduced in 5126324 when we started deferring script loading. This bug has not appeared in a release version yet. It seems that IE 11 sets the readyState on the document at the wrong time when scripts are deferred. Edge and Chrome both do the right thing. This came up during debugging while working on #1111, but this fix is not part of the fix for #1111. Change-Id: Ia42466acdced7ca67fed5a6e8270620b7d8dcd50
joeyparrish
added a commit
that referenced
this issue
Dec 5, 2017
Prefixed versions of the screen orientation API are not compatible with the unprefixed version. Until there is demand for prefixed versions, only use the unprefixed version (Chrome & Firefox). Prefixed versions should be supported through a polyfill, if at all. This also fixes a bug in the demo app that caused the screen orientation exception to be silently ignored. Closes #1111 Change-Id: I9a6e963e6312983bc4bf629ecb2b8e1ad782c49c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When UI elements change state in the demo, the URL hash is supposed to change to reflect that. That is no longer working in Edge. Testing older releases reveals that this was working in v2.2.2 and broken in v2.2.3.
The text was updated successfully, but these errors were encountered: