-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angel One HLS asset failures #1137
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
The encrypted version is failing, too. I'm looking into it. |
The encrypted version fails because we aren't fetching enough of the segments to find the tfdt box and extract the timestamp. The clear version fails because the text stream starts at 0 and the video & audio streams start at 8+change, so the HLS parser sets presentationTimeOffset to 0. |
shaka-bot
pushed a commit
that referenced
this issue
Nov 21, 2017
This increases the amount of data we fetch to get HLS segment start times. The presence of a large PSSH box in Widevine-encrypted content was pushing the "tfdt" box past the 1kB mark, so we will now fetch 2kB. Issue #1137 References FR in shaka-project/shaka-packager#294 Change-Id: I51a1407c4d992e42d07c3e6c6c501051100d1620
Fix cherry-picked for v2.2.7. |
joeyparrish
added a commit
that referenced
this issue
Nov 27, 2017
The version encoded by Apple had serious issues with timestamps misaligned between video and text. The asset has been re-encoded and re-packaged using Shaka Packager. Closes #1137 Change-Id: Ie2ae620d79c7f7611810b558e9a05884a54535bf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
On the nightly, the Angel One HLS assets are both behaving incorrectly.
The clear one seems to infer the start time as being ~8.5 seconds before the real start time, which results in there being a large gap at the start of the video.
In a possibly-related note, the Widevine-encrypted version outputs a BUFFER_READ_OUT_OF_BOUNDS error with the following stack trace:
This only happens on the nightly, so it's probably the result of a recent CL; we've had a number that have to do with time offset in HLS recently, so I'm not sure which.
The text was updated successfully, but these errors were encountered: