Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to play a just started live broadcast #1150

Closed
crazytoad opened this issue Nov 22, 2017 · 3 comments
Closed

Unable to play a just started live broadcast #1150

crazytoad opened this issue Nov 22, 2017 · 3 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@crazytoad
Copy link

Have you read the FAQ and checked for duplicate issues:
yes

What version of Shaka Player are you using:
2.2.6

Can you reproduce the issue with our latest release version:
yes

Can you reproduce the issue with the latest code from master:
yes

Are you using the demo app or your own custom app:
custom app

If custom app, can you reproduce the issue using our demo app:
yes

What browser and OS are you using:
chrome 62 macOS 10.12.6

What are the manifest and license server URIs:
(you can send the URIs to [email protected] instead, but please use GitHub and the template for the rest)
Email sent

What did you do?
Connected to a live stream the moment it started broadcasting and the first manifest was available

What did you expect to happen?
Video to start playing

What actually happened?
Video never plays

This issue appeared as of v2.2.3 and I've narrowed it down to the fix for #1061 (commit 449cd3e). It looks like if you update that to only return from onPollGapJump_() while seeking and not from a segment getting appended it fixes the issue:

diff --git a/lib/media/playhead.js b/lib/media/playhead.js
index 3c4e1c8..9200877 100644
--- a/lib/media/playhead.js
+++ b/lib/media/playhead.js
@@ -347,7 +347,7 @@ shaka.media.Playhead.prototype.onPollGapJump_ = function() {
   // Don't gap jump before the video is ready to play.
   if (this.video_.readyState == 0) return;
   // Don't gap jump while seeking, to prevent a race condition.
-  if (this.video_.seeking) return;
+  if (this.video_.seeking && !this.hadSegmentAppended_) return;
   // Don't gap jump while paused, so that you don't constantly jump ahead while
   // paused on a livestream.
   if (this.video_.paused) return;
shaka-bot pushed a commit that referenced this issue Nov 22, 2017
This also changes the tests so they mirror the |video.seeking|
property to reveal the problem that change created.  That change
broke seeking into gaps and gaps before the start.

Issue #1149
Issue #1150
Reopens #1061

Change-Id: I18fb65b1529acdacd0becd77078780625e0a955b
@TheModMaker
Copy link
Contributor

We just reverted the fix for #1061. Can you test again to see if that fixes it? You can use the nightly, but be sure to clear the cache and check the version starts with v2.2.0 followed by a number that is at least 133:

https://nightly-dot-shaka-player-demo.appspot.com/demo/

@TheModMaker TheModMaker added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 22, 2017
@crazytoad
Copy link
Author

I can confirm the issue is fixed in v2.2.0-133-g59b48f0 - thank you!

@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed needs triage status: waiting on response Waiting on a response from the reporter(s) of the issue labels Nov 22, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Nov 27, 2017
@joeyparrish
Copy link
Member

Fix cherry-picked for v2.2.7.

joeyparrish pushed a commit that referenced this issue Nov 27, 2017
This also changes the tests so they mirror the |video.seeking|
property to reveal the problem that change created.  That change
broke seeking into gaps and gaps before the start.

Issue #1149
Issue #1150
Reopens #1061

Change-Id: I18fb65b1529acdacd0becd77078780625e0a955b
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants